Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(ll): adapt the fuse-abi crate #290

Closed
wants to merge 4 commits into from

Conversation

mkroening
Copy link

Hi there,

I have published the fuse-abi crate for autogenerated, up-to-date bindings to FUSE devices, which is also usable in no_std environments such as OS kernels.

This initial unclean port of fuser to fuse-abi seems to work in practice, according to CI.
The most important difference to fuser::ll::fuse_abi is that the crate's struct's fields are not feature-gated. This would require fuser to adapt another approach to access to versioned fields which change the struct's size. This does not happen a lot, but there are cases such as with fuse_mknod_in, which libfuse handles like this.

If you are open to such an approach or have another idea to this issue, I'd be happy to continue working on this. I just wanted to test the waters before putting in more work. :)

Signed-off-by: Martin Kröning <martin.kroening@eonerc.rwth-aachen.de>
Signed-off-by: Martin Kröning <martin.kroening@eonerc.rwth-aachen.de>
Signed-off-by: Martin Kröning <martin.kroening@eonerc.rwth-aachen.de>
Signed-off-by: Martin Kröning <martin.kroening@eonerc.rwth-aachen.de>
@cberner
Copy link
Owner

cberner commented Jul 14, 2024

I prefer to minimize the number of dependencies in my crates, so don't want to merge this. Looks neat though, thanks for submitting!

@cberner cberner closed this Jul 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants