b-tagging first improvements -- need to check #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| thus this may not be correct for large impact parameters (more than 3 mm) | ||
| It also computes W, the likelihood value for the jet to contain beauty, | ||
| using a likelihood ratio method for each particle in the jet. | ||
| Computes TCHE and TCHP for the jet for b-tagging''' |
There was a problem hiding this comment.
this documentation lacks information about module configuration, please provide an example configuration here as done for other analyzers.
also, the documentation should say what is going to be added to each track, e.g.
track.IP : impact parameter in mm
track.dIP : impact parameter uncertainty in mm
in the same way, the documentation should say what is going to be added to each jet.
| primary vertex, with respets to the primary vertex | ||
|
|
||
| New attributes for particles.path (from compute_theta_0) : | ||
| * theta_0 = 1/sqrt(2) * gaussian width of the scattering angle |
There was a problem hiding this comment.
not clear, please add a reference to the equation of theta 0 in the pdg
selvaggi
pushed a commit
to selvaggi/heppy
that referenced
this pull request
Nov 14, 2016
working with new edm. tutorial reviewed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.