-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run gps from any directory (except MuJoCo experiments) #13
Conversation
@@ -60,18 +66,25 @@ def save_to_npz(filename, key, value): | |||
np.savez(filename, **tmp) | |||
|
|||
|
|||
def load_pose_from_npz(filename, actuator_name, target_number, data_time): | |||
def load_pose_from_npz(filename, actuator_name, target_number, data_time, | |||
default_ja=np.zeros(7), default_ee_pos=np.zeros(3), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you set these as a constant at the top of the file instead of arguments to the function?
Okay fixed, can I merge now? |
Yes, though people should be aware that this breaks any of their non-checked in hyperparams files (and they need to change those two lines of code with the directory) |
Should we just keep the old version then? I mean the extra "../" is kind of stupid but trivial. |
Is there a clean way to make this change without affecting the hyperparams file? |
Yes, those changes don't really do anything except make the code look a little better, so I can just remove them. |
Ok, please do then. On Sun, Apr 17, 2016 at 4:20 PM, Xin Yu Tan notifications@github.com
|
b9a44bd
to
fa12b4a
Compare
Cost config & initialization
Run gps from any directory (except MuJoCo experiments)