Skip to content

Commit

Permalink
Revert "Set PopupView as parent of PopupWindow_QQuickView"
Browse files Browse the repository at this point in the history
This reverts commit 09200b3.
That commit did fix a real problem (and a memory leak), but that problem should not occur anymore because of d18f9b3, and the commit caused other problems that are not quite trivial (musescore#22640 and musescore#22641). Therefore, we'll revert this commit for now.
  • Loading branch information
cbjeukendrup committed Apr 30, 2024
1 parent f2bf2bd commit 24a2088
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/framework/uicomponents/view/popupview.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@ void PopupView::init()
return;
}

m_window = new PopupWindow_QQuickView(this);
m_window = new PopupWindow_QQuickView();
m_window->init(engine, isDialog(), frameless());
m_window->setOnHidden([this]() { onHidden(); });
m_window->setContent(m_component, m_contentItem);
Expand Down

0 comments on commit 24a2088

Please sign in to comment.