Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace Instrument button in instrument panel does not work #22640

Closed
zacjansheski opened this issue Apr 30, 2024 · 1 comment · Fixed by #22644 or #22681
Closed

Replace Instrument button in instrument panel does not work #22640

zacjansheski opened this issue Apr 30, 2024 · 1 comment · Fixed by #22644 or #22681
Assignees
@Eism
Labels
P0 Priority: Critical regression Regression on a prior release UI Visual issues affecting the UI (not notation)

Comments

@zacjansheski
Copy link
Contributor

zacjansheski commented Apr 30, 2024 •
edited
Loading

Issue type

UI bug (incorrect info or interface appearance)

Bug description

Replace Instrument button in instrument panel does not work

Steps to reproduce

  1. Go to instrument panel
  2. Select the cog wheel next to an instrument
  3. Select "Replace Instrument"
  4. Select Instrument window should appear. Nothing happens

Screenshots/Screen recordings

No response

MuseScore Version

OS: macOS 14.4, Arch.: x86_64, MuseScore Studio version (64-bit): 4.3.0-241211748, revision: github-musescore-musescore-f2bf2bd

Regression

Yes, this used to work in a previous version of MuseScore 4.x

Operating system

Mac OS 14

Additional context

No response
@muse-bot muse-bot added regression Regression on a prior release UI Visual issues affecting the UI (not notation) labels Apr 30, 2024
@zacjansheski zacjansheski added the P0 Priority: Critical label Apr 30, 2024
Eism added a commit to Eism/MuseScore that referenced this issue Apr 30, 2024
@Eism
fixed musescore#22640: Use async instead of Qt.callLater after closin…
ced4b7e 
…g the popup
@Eism Eism mentioned this issue Apr 30, 2024
Closed
cbjeukendrup added a commit to cbjeukendrup/MuseScore that referenced this issue Apr 30, 2024
@cbjeukendrup
Revert "Set PopupView as parent of PopupWindow_QQuickView"
24a2088 
This reverts commit 09200b3.
That commit did fix a real problem (and a memory leak), but that problem should not occur anymore because of d18f9b3, and the commit caused other problems that are not quite trivial (musescore#22640 and musescore#22641). Therefore, we'll revert this commit for now.
@cbjeukendrup cbjeukendrup mentioned this issue Apr 30, 2024
Merged
@Eism Eism linked a pull request May 1, 2024 that will close this issue
Revert "Set PopupView as parent of PopupWindow_QQuickView" #22644
Merged
@bkunda
Copy link

bkunda commented May 3, 2024

Same status as #22641

cbjeukendrup added a commit to cbjeukendrup/MuseScore that referenced this issue May 4, 2024
@cbjeukendrup
Revert "Set PopupView as parent of PopupWindow_QQuickView"
1a82b43 
This reverts commit 2fa36e3.
That commit did fix a real problem (and a memory leak), but that problem should not occur anymore because of d18f9b3, and the commit caused other problems that are not quite trivial (musescore#22640 and musescore#22641). Therefore, we'll revert this commit for now.
@cbjeukendrup cbjeukendrup mentioned this issue May 4, 2024
Merged
@cbjeukendrup cbjeukendrup mentioned this issue May 17, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Eism Eism

Labels
P0 Priority: Critical regression Regression on a prior release UI Visual issues affecting the UI (not notation)
Projects
No open projects
MuseScore Studio 4.3
Status: Done
Milestone
No milestone
4 participants
@Eism @muse-bot @zacjansheski @bkunda