Skip to content

Commit

Permalink
Migrate perfetto to flutter/third_party
Browse files Browse the repository at this point in the history
Migrate perfetto from the buildroot's third_party directory to the
engine's.

Issue: flutter/flutter#144808
Part of: flutter/flutter#67373
  • Loading branch information
cbracken committed Mar 12, 2024
1 parent 12a6da3 commit bb66085
Show file tree
Hide file tree
Showing 3 changed files with 13 additions and 11 deletions.
2 changes: 1 addition & 1 deletion DEPS
Original file line number Diff line number Diff line change
Expand Up @@ -333,7 +333,7 @@ deps = {
'src/flutter/third_party/boringssl/src':
'https://boringssl.googlesource.com/boringssl.git' + '@' + Var('dart_boringssl_rev'),

'src/third_party/perfetto':
'src/flutter/third_party/perfetto':
Var('flutter_git') + "/third_party/perfetto" + '@' + Var('dart_perfetto_rev'),

'src/flutter/third_party/protobuf':
Expand Down
2 changes: 2 additions & 0 deletions build_overrides/build.gni
Original file line number Diff line number Diff line change
Expand Up @@ -11,3 +11,5 @@ build_with_chromium = false
# targets to distinguish embedder builds from Perfetto standalone builds, and
# builds in the Android tree.
perfetto_build_with_embedder = true

perfetto_root_path = "//flutter/third_party/perfetto/"
20 changes: 10 additions & 10 deletions tools/licenses/lib/paths.dart
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,16 @@ final Set<String> skippedPaths = <String>{
r'flutter/third_party/libwebp/webp_js',
r'flutter/third_party/ninja', // build system
r'flutter/third_party/ocmock', // only used for tests
r'flutter/third_party/perfetto/debian', // contains nothing that ends up in the binary executable
r'flutter/third_party/perfetto/infra', // contains nothing that ends up in the binary executable
r'flutter/third_party/perfetto/protos', // contains nothing that ends up in the binary executable
r'flutter/third_party/perfetto/python/perfetto/trace_processor', // contains nothing that ends up in the binary executable
r'flutter/third_party/perfetto/src/ipc', // contains nothing that ends up in the binary executable
r'flutter/third_party/perfetto/src/profiling/memory', // contains nothing that ends up in the binary executable
r'flutter/third_party/perfetto/src/tools', // contains nothing that ends up in the binary executable
r'flutter/third_party/perfetto/src/trace_processor', // contains nothing that ends up in the binary executable
r'flutter/third_party/perfetto/src/traced', // contains nothing that ends up in the binary executable
r'flutter/third_party/perfetto/src/tracing', // contains nothing that ends up in the binary executable
r'flutter/third_party/pkg/archive', // contains nothing that ends up in the binary executable
r'flutter/third_party/pkg/equatable',
r'flutter/third_party/pkg/flutter_packages',
Expand Down Expand Up @@ -207,16 +217,6 @@ final Set<String> skippedPaths = <String>{
r'third_party/libcxx/utils',
r'third_party/libcxxabi/www',
r'third_party/libxml', // dependency of the testing system that we don't actually use
r'third_party/perfetto/debian', // contains nothing that ends up in the binary executable
r'third_party/perfetto/infra', // contains nothing that ends up in the binary executable
r'third_party/perfetto/protos', // contains nothing that ends up in the binary executable
r'third_party/perfetto/python/perfetto/trace_processor', // contains nothing that ends up in the binary executable
r'third_party/perfetto/src/ipc', // contains nothing that ends up in the binary executable
r'third_party/perfetto/src/profiling/memory', // contains nothing that ends up in the binary executable
r'third_party/perfetto/src/tools', // contains nothing that ends up in the binary executable
r'third_party/perfetto/src/trace_processor', // contains nothing that ends up in the binary executable
r'third_party/perfetto/src/traced', // contains nothing that ends up in the binary executable
r'third_party/perfetto/src/tracing', // contains nothing that ends up in the binary executable
r'third_party/web_dependencies/canvaskit', // redundant; covered by Skia dependencies
r'third_party/zlib/contrib/minizip/miniunz.c', // sample file
r'third_party/zlib/contrib/minizip/minizip.c', // sample file
Expand Down

0 comments on commit bb66085

Please sign in to comment.