-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Average epochs #34
Comments
sorry, accidental posting. :) To use mnelab in class the following features would be necessary (at least from my perspective):
are these features within future scope of mnelab? If so I would like to help at some point but first I'd have to teach myself some pyqt. :) |
and it would be super useful to display code responsible for certain GUI operations (the equivalence of |
I don't have a detailed roadmap for MNELAB, but epoching is definitely at the top of the list. This will require some restructuring (or at least thinking), so I can't say when it will be done. Applying ICA should be easier since computing ICA is already possible, and all that's missing is a simple command. Something like |
And regarding the documentation: there is no documentation yet, this would probably be the most important thing to start adding... |
Some of these features are implemented in the fork we work on with @TyWR. Some of them such as epoching and averaging are working fine, but the structure of the code may not be optimal for long term dev. For others features, some of them are custom plot that may not suit the MNE community. But there is several functions such as ICA and filtering which are pure MNE code that could be merged to the main repo. In addition, we can help to developt new functions that are in neither of the repos |
@vferat PRs welcome - maybe start with applying ICA to raw data? I will also work on some stuff, we should probably coordinate. |
@cbrnr |
Two additional features that are essential for my workflow:
|
@cbrnr Would it possible to set up the Projects tab in your repo to get an overview of what is to be done, or currently in progress ? That would be nice to coordinate the work on different features. I thought about adapting the code from our fork for the handling of epochs & evoked data type. |
@hoechenberger concatenating epochs will be added as part of adding epochs in general. You can already add a reference channel if you go to Edit -> Set reference..., then click on Channel(s) and add a name that doesn't exist - this channel will be added as a new reference. I think documenting the existing features is really the first thing to be done. |
@TyWR I've never used this tab, but if it helps in tracking current progress I can of course set it up. So far I thought that creating issues was sufficient for that, because you can also assign an issue to specific persons. |
Maybe let's stick with opening separate issues for missing features for now. I can assign to people if someone volunteers to implement/fix an issue. |
Great, thank you! |
@mmagnuski could you please clarify what you mean by "epoch selection (by condition/event)"? Do you mean that epoch creation is based on specific events - this is already implemented in MNELAB. Or do you mean selection of epochs in an already existing Epochs object (if so, how is this done with MNE)? |
@cbrnr Hi, I think I might have meant selecting events to epoch by. The other thing is done in MNE with |
Whats the latest on this topic? Does anyone have a branch attempting epoch plotting that I can look at? No stress if not, just wondering. |
@rob-luke epoching is already implemented (which includes plotting). I think the only thing missing from this issue is creating an Evoked object from Epochs. |
Sorry I was not very precise with my language, I was interested in evoked plotting. But I think you have answered my question, it’s not currently hiding in a branch somewhere and needs to be implemented. Thanks for the update. |
This has now been implemented, currently only as a plotting option for |
Summary of feature requests from this discussion:
The text was updated successfully, but these errors were encountered: