Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Epochs/Evoked data handling #42

Closed
TyWR opened this issue Jul 4, 2019 · 3 comments
Closed

Epochs/Evoked data handling #42

TyWR opened this issue Jul 4, 2019 · 3 comments

Comments

@TyWR
Copy link
Contributor

TyWR commented Jul 4, 2019

As mentionned in #34 , I could work on the handling of Epochs and Evoked data.

A suggestion for the changes in the structure of the code would be

  • Change model.current['raw'] to model.current['data']
  • Add a new keyword model.current['type'] set to 'raw', 'epochs' or 'evoked' depending on the type of data loaded.
  • Add an epoching window close to

Screenshot from 2019-07-04 15-47-57

@cbrnr
Copy link
Owner

cbrnr commented Jul 5, 2019

Sounds good. I assume creating epochs is based on events, right? Is it possible to select multiple event types? Maybe "Choose Marker" should be reworded to "Event type" to be more consistent with MNE terminology. Also, maybe we should have some defaults for the interval values (e.g. -1 and 1s).

@cbrnr cbrnr changed the title Epochs - Evoked data handling Epochs/Evoked data handling Jul 5, 2019
@mmagnuski
Copy link

The defaults for interval values could be the same as in mne which is: tmin=-0.2, tmax=0.5.

@cbrnr
Copy link
Owner

cbrnr commented Aug 12, 2019

Implemented in #45.

@cbrnr cbrnr closed this as completed Aug 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants