WIP: Improve the dialog for picking bad channels. #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the channel picker dialog does a good job of allowing the user to choose bad channels, but has a few shortcomings: (1) It's difficult to see, at a glance, which channels have already been marked as bad. (2) When the user begins clicking on new channels to mark as bad, any previously marked channels become unselected. Thus, making sure you've selected everything you want requires careful scrolling. Using two list widgets to shuffle channels goes some lengths to solve both these issues.
|
A new channel properties dialog is available in master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the channel picker dialog does a good job of allowing the user to
choose bad channels, but has a few shortcomings:
(1) It's difficult to see, at a glance, which channels have already been marked
as bad.
(2) When the user begins clicking on new channels to mark as bad, any
previously marked channels become unselected. Thus, making sure you've selected
everything you want requires careful scrolling.
Using two list widgets to shuffle channels goes some lengths to solve both
these issues.