-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build only 64bit wheels #41
Conversation
Could it be that we run cibuildwheel on the three platforms, and we actually build wheels for all three platforms three times? |
We build wheels for 3.7, 3.8 and 3.9 on each of the three platforms... do you mean that? |
OK, this makes sense. No, I thought we were building wheels for all platforms on each platform. Do you know how to access the artifacts uploaded in each job? For example, the output on |
Click on It's 5 because no macos-arm64 wheel is created for python3.7. |
Related question: why are there 6 wheels for Linux? 5 for macOS and 3 for Windows make sense. Another idea: we could drop support for Python 3.7 and add 3.10 instead. |
Fine with me, though I'd wait until our dependencies have wheels for 3.10 😅. |
According to https://github.com/pypa/manylinux/ these should be different builds though.
Definitely. Which packages are currently missing? |
Strange 🤔
I just checked (on windows), the core dependencies seem to work, but numba (used for heartbeat detection) and pyedflib (used for testing |
Thanks @hofaflo! Numba should be available soon (numba/numba#7562). Not sure about pyedflib though, we could ask, but let's just wait a couple of weeks. I'll create an issue so that we don't forget. Not sure what's up with manylinux, I'll create a separate issue so that I can merge this PR. |
No description provided.