Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build only 64bit wheels #41

Merged
merged 2 commits into from
Dec 1, 2021
Merged

Build only 64bit wheels #41

merged 2 commits into from
Dec 1, 2021

Conversation

hofaflo
Copy link
Collaborator

@hofaflo hofaflo commented Dec 1, 2021

No description provided.

@cbrnr
Copy link
Owner

cbrnr commented Dec 1, 2021

Could it be that we run cibuildwheel on the three platforms, and we actually build wheels for all three platforms three times?

@hofaflo
Copy link
Collaborator Author

hofaflo commented Dec 1, 2021

We build wheels for 3.7, 3.8 and 3.9 on each of the three platforms... do you mean that?

@cbrnr
Copy link
Owner

cbrnr commented Dec 1, 2021

OK, this makes sense. No, I thought we were building wheels for all platforms on each platform.

Do you know how to access the artifacts uploaded in each job? For example, the output on macos-10.15 says that 5 files were uploaded. Where are these files? And why 5?

@hofaflo
Copy link
Collaborator Author

hofaflo commented Dec 1, 2021

Click on Details on any of the "Test"-jobs, then on Summary on the top left, then scroll to the bottom and click on artifact (a zip containing the artifacts from all jobs).

It's 5 because no macos-arm64 wheel is created for python3.7.

@cbrnr
Copy link
Owner

cbrnr commented Dec 1, 2021

Related question: why are there 6 wheels for Linux? 5 for macOS and 3 for Windows make sense.

Another idea: we could drop support for Python 3.7 and add 3.10 instead.

@hofaflo
Copy link
Collaborator Author

hofaflo commented Dec 1, 2021

Related question: why are there 6 wheels for Linux? 5 for macOS and 3 for Windows make sense.

manylinux1 and manylinux2014... but apparently only one wheel is built for each python version and then duplicated with a different name 🤷

Another idea: we could drop support for Python 3.7 and add 3.10 instead.

Fine with me, though I'd wait until our dependencies have wheels for 3.10 😅.

@cbrnr
Copy link
Owner

cbrnr commented Dec 1, 2021

manylinux1 and manylinux2014... but apparently only one wheel is built for each python version and then duplicated with a different name 🤷

According to https://github.com/pypa/manylinux/ these should be different builds though.

Fine with me, though I'd wait until our dependencies have wheels for 3.10 😅.

Definitely. Which packages are currently missing?

@hofaflo
Copy link
Collaborator Author

hofaflo commented Dec 1, 2021

According to https://github.com/pypa/manylinux/ these should be different builds though.

Strange 🤔

Definitely. Which packages are currently missing?

I just checked (on windows), the core dependencies seem to work, but numba (used for heartbeat detection) and pyedflib (used for testing read_mesa) don't.

@cbrnr cbrnr merged commit 0faf0a1 into cbrnr:main Dec 1, 2021
@cbrnr
Copy link
Owner

cbrnr commented Dec 1, 2021

Thanks @hofaflo!

Numba should be available soon (numba/numba#7562). Not sure about pyedflib though, we could ask, but let's just wait a couple of weeks. I'll create an issue so that we don't forget.

Not sure what's up with manylinux, I'll create a separate issue so that I can merge this PR.

@cbrnr cbrnr mentioned this pull request Dec 1, 2021
@hofaflo hofaflo deleted the cibw-reduce branch December 1, 2021 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants