Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting rcshutdown_timeout without kern.init_shutdown_timeout #374

Closed
marko-turk opened this issue Jan 20, 2019 · 3 comments
Assignees

Comments

@marko-turk
Copy link

@marko-turk marko-turk commented Jan 20, 2019

Hi,

cbsd increases the default rcshutdown_timeout but doesn't set kern.init_shutdown_timeout.

From the rc.conf(5) manpage:

     rcshutdown_timeout                                                                                   
                 (int) If set, start a watchdog timer in the background which                             
                 will terminate rc.shutdown if shutdown(8) has not completed                              
                 within the specified time (in seconds).  Notice that in                                  
                 addition to this soft timeout, init(8) also applies a hard                               
                 timeout for the execution of rc.shutdown.  This is configured                            
                 via sysctl(8) variable kern.init_shutdown_timeout and                                    
                 defaults to 120 seconds.  Setting the value of                                           
                 rcshutdown_timeout to more than 120 seconds will have no                                 
                 effect until the sysctl(8) variable                                                      
                 kern.init_shutdown_timeout is also increased.                                            

Mandatory info for bug reports:

FreeBSD version ( uname -a ):
FreeBSD fbsd.my.domain 12.0-CURRENT FreeBSD 12.0-CURRENT #3 f5a583ad15e(HEAD): Thu Jul 5 00:07:37 CEST 2018 xxx@xxxx:/xxxx/amd64.amd64/sys/GENERIC amd64

CBSD version ( cbsd version ):
11.2.1

BR/Marko

@olevole olevole self-assigned this Jan 20, 2019
@olevole

This comment has been minimized.

Copy link
Collaborator

@olevole olevole commented Jan 20, 2019

Yes you are right. At a minimum we need to add a notice/message for this.

olevole added a commit that referenced this issue Jan 21, 2019
since we historically configure rcshutdown_timeout parameter also check the sysctl kern.init_shutdown_timeout
due to rcshutdown_timeout has no effect when kern.init_shutdown_timeout less

Pointed out: Marko Turk (marko-turk), Issue #374
@olevole

This comment has been minimized.

Copy link
Collaborator

@olevole olevole commented Jan 21, 2019

Thx, commited

@olevole olevole closed this Jan 21, 2019
@olevole

This comment has been minimized.

Copy link
Collaborator

@olevole olevole commented Feb 16, 2019

commited to ports tree: 12.0.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.