Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ConsoleZ closes without explanation on bad config #358

Closed
Whiteknight opened this issue Aug 3, 2016 · 5 comments
Closed

ConsoleZ closes without explanation on bad config #358

Whiteknight opened this issue Aug 3, 2016 · 5 comments
Assignees
@cbucher
Labels
feature request
Milestone
1.17.1

Comments

@Whiteknight
Copy link

If the config in console.xml is invalid, the ConsoleZ program will close immediately with no error message or indication of the problem.

I have seen this problem in three scenarios at different times (the third being the most recent):

  1. XML formatting errors (unclosed tags, caused by bad copy)
  2. XML structure changes (caused by copying an old console.xml to a new install)
  3. Missing shell exe (caused by an upgrade to new msysgit, which installed to a new path)

In all three cases, some kind of error message about what the error is and (even better) what could be done to correct the issue would be helpful.

Allowing the program to open with some default config while the issue is being addressed would also be helpful.
@cbucher
Copy link
Owner

cbucher commented Aug 4, 2016

I have seen this problem in three scenarios at different times (the third being the most recent):

  1. XML formatting errors (unclosed tags, caused by bad copy)

This case only occurs when user modify the configuration file by himself.
Last versions of ConsoleZ start by ignoring the corrupt file. I can add an error message popup too.

  1. XML structure changes (caused by copying an old console.xml to a new install)

Strange... configuration file is always backward compatible. I can use my current configuration file with the old Console2 application. And I can use Console2 configuration file with every ConsoleZ version.

  1. Missing shell exe (caused by an upgrade to new msysgit, which installed to a new path)

Yes we can start a failover shell when zero shell has started.

@cbucher cbucher self-assigned this Aug 4, 2016
@Whiteknight
Copy link
Author

Case #2 might also be related to Case #1 so we can probably ignore it. Having an error popup in case the file is unreadable for any reason would be a huge help.

@cbucher
Copy link
Owner

cbucher commented Aug 5, 2016 •
edited

If you start ConsoleZ with a broken configuration file, you will use default configuration. So when you save the configuration (by editing settings, selecting views, …), broken file is replaced by new one.
Should we (only when configuration file is broken):

  • ask for replacement when saving the configuration file?
  • backup the configfuration file?
  • just add a notice in the warning popup?

cbucher added a commit that referenced this issue Aug 8, 2016
@cbucher
#358 Start a safe console when no console started
0cdacbd
cbucher added a commit that referenced this issue Aug 10, 2016
@cbucher
#358 loading/saving settings code has been rewritten
1beb0a4 
code is simplified
support an "empty" configuration file
support no tabs configured
cbucher added a commit that referenced this issue Aug 12, 2016
@cbucher
#358 Configuration file is no longer saved when user open settings di…
154616f 
…alog.

Configuration file is saved when user click on "OK" button.
cbucher added a commit that referenced this issue Aug 17, 2016
@cbucher
#358 A popup is displayed when XML parsing fails.
3421fab 
This popup contains 3 buttons:
- Cancel: The application terminates
- Try Again: You can fix the XML and retry loading
- Continue: The application ignores this configuration file and uses default settings
cbucher added a commit that referenced this issue Aug 17, 2016
@cbucher
#358 Simplified configuration file in resource (we use default values).
427d63b
@cbucher
Copy link
Owner

cbucher commented Aug 18, 2016

@Whiteknight Please test last experimental release - version 1.17.1.16230

@cbucher cbucher added this to the 1.17.1 milestone Aug 19, 2016
@VarunAgw VarunAgw mentioned this issue Aug 21, 2016
Open
@cbucher
Copy link
Owner

cbucher commented Aug 23, 2016

@Whiteknight Please try last experimental release - version 1.17.1.16236

@cbucher cbucher closed this as completed Sep 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cbucher cbucher

Labels
feature request
Projects
None yet
Milestone
1.17.1
Development

No branches or pull requests
2 participants
@Whiteknight @cbucher