added main benchmark to all pages, labeled all footer buttons, labele…

[dos077]

Fixes

Fixes #999 by @brenoferreira

Description

Change the main divs in all pages to the

tag for benchmarks.
Added aria labels to all footer icons.
Labeled the header as primary and footer as footerlinks for uniqueness.
Change the nested in the to

so benchmarks are not nested.

Technical details

Tests

Screenshots

Checklist

• My pull request has a descriptive title (not a vague title like Update index.md).
• My pull request targets the master branch of the repository.
• My commit messages follow best practices.
• My code follows the established code style of the repository.
• I added tests for the changes I made (if applicable).
• I added or updated documentation (if applicable).
• I tried running the project locally and verified that there are no
  visible errors.

Developer Certificate of Origin

Developer Certificate of Origin

Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

[ayanchoudhary]

Also, I think aria-labels should be lowercase. deferring to @akmadian for further suggestions.

[ayanchoudhary]

I guess it would be better to leave the markup of this tag to be aside itself since it follows the rules of good HTML semantics and also helps in improving accessibility.

[dos077]

I changed that because OP's csv file reported this issue:https://dequeuniversity.com/rules/axe/3.3/landmark-complementary-is-top-level

I've seen aside used in main all the time, but this aside seems to be contained in a column

. Since there's already a container grid structure, I think the aside tag is out of place. It's not a big issue, I will change it back.

I am not that familiar with aria-labels, usually framework handles it, glad you point out my inconsistency, I will change them lower cases and maybe tighten up the naming as well.

[zackkrida]

@ayanchoudhary could you re-review this this week? I'll merge once you approve; thanks!

[ayanchoudhary]

Looks good :) @zackkrida I guess this is ready to be merged