This repository has been archived by the owner on May 1, 2019. It is now read-only.
Add image methods #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cknitt
reviewed
Apr 3, 2019
src/Image.re
Outdated
| external abortPrefetch: requestId => unit = "abortPrefetch"; | ||
|
|
||
| [@bs.module "react-native"] [@bs.scope "Image"] | ||
| external queryCache: (~urls: array(string)) => unit = "queryCache"; |
There was a problem hiding this comment.
We should be consistent in whether we use uri or url. (Please also check what is used in other components/apis.)
src/Image.re
Outdated
|
|
||
| [@bs.module "react-native"] [@bs.scope "Image"] | ||
| external resolveAssetSource: Source.t => unit = "resolveAssetSource"; | ||
| external resolveAssetSourceInt: int => unit = "resolveAssetSource"; |
There was a problem hiding this comment.
These functions should actually return Source.t, not unit.
There was a problem hiding this comment.
We probably don't need resolveAssetSource, it is basically identity, right?
And resolveAssetSourceInt should probably be
external resolveAssetSource: Packager.required => Source.t = "resolveAssetSource";(and Source.fromRequired should be removed?)?
fhammerschmidt
force-pushed
the
feature/image-methods
branch
3 times, most recently
from
0c44ca6
to
2e5d0ab
Compare
fhammerschmidt
force-pushed
the
feature/image-methods
branch
from
2e5d0ab
to
e8fbada
Compare
cknitt
approved these changes
Apr 4, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If it's okay I will submit the same to bs-react-native.