-
Notifications
You must be signed in to change notification settings - Fork 489
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace BLAKE2b with BLAKE3 #519
Conversation
There seems to be some problem building the AVX512 version on Travis (too old GCC perhaps?). I'll let it be for now, but I can have a look at it later if you're interested in merging this PR. |
I did another test where I built KDAB/hotspot@a7c2ecb1 with ccache 3.7.7 from Debian
ccache master (42939f0)
This PR
Based on this limited testing it seems like this version is faster than 3.7.7 which is faster than current master. |
I took a look at the CI failure and the problem seems to be that GCC 5.4 generates Adding |
5c3c69d
to
02b9a74
Compare
I've now rebased this PR on the latest master and update BLAKE3 to the first release of the C implementation. Following the discussion in #503 I've also reverted my digest size change and the size is now back to 160 bits as it was before (in a separate commit to make it easy to go one way or the other). With the latest BLAKE3 release all build errors are fixed and performance is a tiny bit better than before. On my computer I now get:
|
I've updated BLAKE3 to the latest release BLAKE3-team/BLAKE3@c-0.2.2 and rebased on latest ccache master. Updated performance numbers now look like this:
Compared to master (e0f5063):
|
35f1ecb
to
3367633
Compare
I've rebased on top of latest master, ported the build to cmake and updated to latest BLAKE3. Running
Compared with this when using this PR:
|
All .c (except main.c), .S and .h files from the c directory in https://github.com/BLAKE3-team/BLAKE3
Thanks! |
Description
Replace the BLAKE2b hash function with BLAKE3 (see #503). The BLAKE3 source files are added as third_party sources and built when building ccache.
I've compared the performance on my machine by running
make CXX=/usr/bin/g++ performance
.On master (42939f0):
This PR:
This PR but all BLAKE3 sources built with
-O3
instead of-O2
: