Add permissions check #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wagnerlmichael
commented
May 3, 2024
.pre-commit-config.yaml
Outdated
Comment on lines
3
to
6
| #- repo: https://github.com/adrienverge/yamllint | ||
| # rev: v1.32.0 | ||
| # hooks: | ||
| # - id: yamllint |
There was a problem hiding this comment.
Temporarily commented out because I made the branch name too long
There was a problem hiding this comment.
[Question, non-blocking] Out of curiosity, how does the branch name affect the yamllint hook?
wagnerlmichael
commented
May 3, 2024
.github/workflows/pre-commit.yaml
Outdated
| @@ -13,4 +13,4 @@ jobs: | |||
| uses: actions/checkout@v4 | |||
|
|
|||
| - name: Run pre-commit checks | |||
| uses: ccao-data/actions/pre-commit@main | |||
| uses: ccao-data/actions/pre-commit@add-step-to-troubleshoot-intermittent-caching-errors | |||
There was a problem hiding this comment.
Will revert this after review
wagnerlmichael
commented
May 3, 2024
jeancochrane
approved these changes
May 3, 2024
.pre-commit-config.yaml
Outdated
Comment on lines
3
to
6
| #- repo: https://github.com/adrienverge/yamllint | ||
| # rev: v1.32.0 | ||
| # hooks: | ||
| # - id: yamllint |
There was a problem hiding this comment.
[Question, non-blocking] Out of curiosity, how does the branch name affect the yamllint hook?
|
#30 (comment), @jeancochrane the length of the branch name when it is referenced in |
wagnerlmichael
deleted the
add-step-to-troubleshoot-intermittent-caching-errors
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a step in the pre-commit action that prints permissions of files in the R cache directory. Hopefully this helps us debug known cache issues.
Successful run here