Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove sale_filter vars and add sv_is_outlier #16

Merged
merged 1 commit into from
Dec 18, 2023

Conversation

wrridgeway
Copy link
Member

No description provided.

@wrridgeway wrridgeway linked an issue Dec 15, 2023 that may be closed by this pull request
Copy link

codecov bot commented Dec 15, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ad3b1c4) 100.00% compared to head (7dfdba8) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##            master       #16   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            6         6           
  Lines          382       382           
=========================================
  Hits           382       382           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wrridgeway wrridgeway changed the title Remove sale_filter_count vars and add sv_is_outlier Remove sale_filter vars and add sv_is_outlier Dec 15, 2023
@wrridgeway wrridgeway changed the title Remove sale_filter vars and add sv_is_outlier Remove sale_filter vars and add sv_is_outlier Dec 15, 2023
@wrridgeway wrridgeway changed the title Remove sale_filter vars and add sv_is_outlier Remove sale_filter vars and add sv_is_outlier Dec 15, 2023
@wrridgeway wrridgeway marked this pull request as ready for review December 15, 2023 22:50
@wrridgeway wrridgeway requested a review from a team as a code owner December 15, 2023 22:50
Copy link
Member

@dfsnow dfsnow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @wrridgeway!

@wrridgeway wrridgeway merged commit 6bdb2f2 into master Dec 18, 2023
12 checks passed
@wrridgeway wrridgeway deleted the 15-add-sv_is_outlier-to-vars_dict branch December 18, 2023 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add sv_is_outlier to vars_dict
2 participants