Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add several new columns to vars dict #18

Merged
merged 2 commits into from
Feb 29, 2024

Conversation

wrridgeway
Copy link
Member

@wrridgeway wrridgeway commented Feb 28, 2024

We need to add:

  • meta_sale_count_past_n_years
  • char_class
  • prox_airport_dnl_total
  • prox_nearest_secondary_road_dist_ft
  • prox_nearest_university_dist_ft
  • prox_nearest_vacant_land_dist_ft
  • ccao_is_active_exe_homeowner
  • ccao_is_corner_lot
  • ccao_n_years_exe_homeowner

@wrridgeway wrridgeway linked an issue Feb 28, 2024 that may be closed by this pull request
@wrridgeway wrridgeway self-assigned this Feb 28, 2024
Copy link

codecov bot commented Feb 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (6bdb2f2) to head (c4354e5).

Additional details and impacted files
@@            Coverage Diff            @@
##            master       #18   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            6         6           
  Lines          382       382           
=========================================
  Hits           382       382           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wrridgeway wrridgeway marked this pull request as ready for review February 28, 2024 21:41
@wrridgeway wrridgeway requested a review from a team as a code owner February 28, 2024 21:41
Copy link
Member

@dfsnow dfsnow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me @wrridgeway

@wrridgeway wrridgeway merged commit 57ea1bb into master Feb 29, 2024
12 checks passed
@wrridgeway wrridgeway deleted the 17-add-several-new-columns-to-vars-dict branch February 29, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add several new columns to vars dict
2 participants