Simplify linear baseline model and bump all R dependencies #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dfsnow
commented
Jan 27, 2024
| @@ -9,7 +9,6 @@ Depends: | |||
| ccao, | |||
| conflicted, | |||
| dplyr, | |||
| embed, | |||
There was a problem hiding this comment.
The embed package has super heavy dependencies (keras, tensorflow), so getting rid of it lightens the dependencies of the main lockfile quite a bit.
dfsnow
commented
Jan 27, 2024
Comment on lines
-80
to
-83
| embed::step_lencode_glm( | ||
| all_of(cat_vars), -has_role("ID"), | ||
| outcome = vars(meta_sale_price) | ||
| ) %>% |
There was a problem hiding this comment.
Dropping this step lets us remove the embed dependency, but it also changes the performance of the linear model. Tagging @ccao-jardine here just as an FYI.
dfsnow
changed the title
|
@jeancochrane @wrridgeway I'm merging this for expediency, but take a look Monday really quick. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR simplifies the linear baseline model by removing the effect encoder step used in its preprocessing pipeline and replacing it with standard one-hot features. This is to reduce the dependency weight of the pipeline, as the
embedrecipes package has enormous sub-dependencies.This PR also bumps all the R/renv dependencies used by each of the pipeline profiles to their latest version available on CRAN.