Initialize columnNameToIndexMap when accessed by client code #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…an use the value without causing setupColumns to be called first.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lazily create and populate the dictionary when calling
-columnNameToIndexMapso that it can be used directly before column values have been accessed. Among other things, this makes it possible to check whether a column exists in a results set (see issue #79).This does change the property from
(atomic, retain)to(readonly), so it will break code that sets this property directly instead of modifying the fmdb-provided dictionary. That seems like a strange use-case to me, but perhaps there's a situation where it is useful that I'm missing.