Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update changelog and bump version to v1.7.2 #1140

Merged
merged 3 commits into from
Jul 8, 2022
Merged

Update changelog and bump version to v1.7.2 #1140

merged 3 commits into from
Jul 8, 2022

Conversation

langner
Copy link
Member

@langner langner commented Jun 28, 2022

No description provided.

@langner langner added this to the v1.7.2 milestone Jun 28, 2022
@langner langner mentioned this pull request Jun 28, 2022
Closed
15 tasks
@codecov
Copy link

codecov bot commented Jun 28, 2022 •
edited
Loading

Codecov Report

Merging #1140 (e9743c2) into release-1.7.2 (8e6892a) will not change coverage.
The diff coverage is 100.00%.

@@              Coverage Diff               @@
##           release-1.7.2    #1140   +/-   ##
==============================================
  Coverage          87.84%   87.84%           
==============================================
  Files                 69       69           
  Lines              13492    13492           
==============================================
  Hits               11852    11852           
  Misses              1640     1640
Impacted Files Coverage Δ
cclib/__init__.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8e6892a...e9743c2. Read the comment docs.

berquist
berquist requested changes Jun 29, 2022
View reviewed changes
Copy link
Member

@berquist berquist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just two changes for the username spelling.

CHANGELOG Outdated Show resolved Hide resolved
doc/sphinx/changelog.rst Show resolved Hide resolved
ANNOUNCE Outdated Show resolved Hide resolved
@langner langner requested a review from berquist July 4, 2022 17:24
@berquist
Copy link
Member

berquist commented Jul 4, 2022

I also merged #1139 this morning.

@langner
Copy link
Member Author

langner commented Jul 5, 2022

I also merged #1139 this morning.

I'll leave that for the next release -- I already branched the release.

@langner
Copy link
Member Author

langner commented Jul 5, 2022

Update THANKS file from 1.6.1 to 1.7.2

I went through the changelog and added persons that were missing.

@berquist
Copy link
Member

berquist commented Jul 8, 2022

I approved, but is this ok to go in?

@langner
Copy link
Member Author

langner commented Jul 8, 2022

I approved, but is this ok to go in?

Yes, please.

@berquist berquist merged commit f148cda into cclib:release-1.7.2 Jul 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@berquist berquist berquist approved these changes

Assignees
No one assigned
Labels
maintenance
Projects
None yet
Milestone
v1.7.2
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@langner @berquist