Migrate graph-specific number properties to use our newer a1 - a8 values. #3368
Comments
nikolas
added a commit
that referenced
this issue
Jul 29, 2024
Issue #3368 Moving forward, it seems all graphs contain a set of fields which all make use of the following properties: * Value * Name (optional) * Min/Max (optional) * Alternate value (optional) We can encapsulate this into an abstraction called a graph "Field". It's still to be determined what this will actually look like on the back-end, I am just trying to understand things conceptually.
Evan-CTL
pushed a commit
that referenced
this issue
Jul 30, 2024
Issue #3368 Moving forward, it seems all graphs contain a set of fields which all make use of the following properties: * Value * Name (optional) * Min/Max (optional) * Alternate value (optional) We can encapsulate this into an abstraction called a graph "Field". It's still to be determined what this will actually look like on the back-end, I am just trying to understand things conceptually.
nikolas
added a commit
that referenced
this issue
Aug 8, 2024
These fields were apparently planned to be used for a graph type but it looks like nothing is actually using them, so we can remove them.
nikolas
added a commit
that referenced
this issue
Aug 8, 2024
These fields were apparently planned to be used for a graph type but it looks like nothing is actually using them, so we can remove them.
nikolas
added a commit
that referenced
this issue
Aug 8, 2024
These fields were apparently planned to be used for a graph type but it looks like nothing is actually using them, so we can remove them.
nikolas
added a commit
that referenced
this issue
Aug 8, 2024
Remove unused graph fields alpha and omega - #3368
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When I first developed a few earlier graph types, I made specific named properties on the Graph model for storing numbers and their labels:
Graph.alpha,Graph.omega: https://github.com/ccnmtl/econplayground/blob/master/econplayground/main/models.py#L281Graph.cobb_douglas_a, etc.. https://github.com/ccnmtl/econplayground/blob/master/econplayground/main/models.py#L346In newer graphs I realized I can just use the same storage fields to represent different parameters in different graph types, as our requirements grew. I called these properties a1, a2, a3, with the "a" signifying "arbitrary". Maybe this is not the best system, but it's the one we have for now, so it would be good to at least unify all graph types to use this system. This will make it easier to change or refactor things if we ever want to do that in the future.
The text was updated successfully, but these errors were encountered: