Django 1.11 #520
Merged
Django 1.11 #520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thraxil
reviewed
Apr 19, 2017
| @@ -14,6 +14,7 @@ class Meta: | |||
| password = factory.PostGenerationMethodCall('set_password', 'test') | |||
| last_name = factory.Sequence(lambda n: "Last%d" % n) | |||
| first_name = factory.Sequence(lambda n: "First%d" % n) | |||
| email = factory.Sequence(lambda n: "username%d@localhost" % n) | |||
There was a problem hiding this comment.
Curious how you figured out that this was missing. I started a 1.11 branch, did the usual bits and hit the failing tests on the mail stuff. Got distracted with other stuff before I could really dig into it, but I don't think this fix was very obvious.
There was a problem hiding this comment.
I put a breakpoint in the DenyFacultyView.send_denied_email and traced through send_mail until I hit this condition. I guessed at that point that the UserFactory was not creating the user with an email.
Looks like this commit changed the behavior in 1.11: django/django@8858631
thraxil
approved these changes
Apr 19, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.