Mediathread replace #496
Merged
Mediathread replace #496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
similar to the `mediathreadsubmit`, abuse the `File` model to mark that a Video has begun an operation that will require updating the mediathread entry once a later operation has finished. When the banzai stuff lands, we should be able to stop doing this, but for now, it's the best way we have to carry state across multiple operations :(
when the video is being converted from FLV to MP4, if there is a known Mediathread asset, create the flag file so a later stage will know to pass along the new URL to mediathread.
after the conversion, if the video that was converted had an associated mediathread asset, we make a POST request to it with the new mp4 URL so it can use that instead of the FLV.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After performing an FLV -> MP4 conversion, if the video has an associated Mediathread asset, we send a POST over there to inform it of the new URL.
The update logic does not yet exist on the Mediathread side, so it will need to be implemented before we can turn this feature on (it's behind a waffle switch).
The new bits in
wardenclyffe/mediathread/tasks.pywill be useful for looking at to implement that.As it is currently implemented:
https://mediathread.ccnmtl.columbia.edu/asset/1234/, sticksupdate/on the end and makes aPOSTrequest there/save/when a new video is created, but stripped down to only the fields that would change as a result of the conversion (ie, we expect all the metadata and size info to stay the same)Any of that we can definitely change if we think a different endpoint or parameter setup would make implementation of the Meth side simpler.