allReady does not work.

[ElvishJerricco]

With subs-cache 0.1.0 and meteor 1.2 or 1.3, it appears that the allReady reactive variable is not successfully set when subscriptions become ready.

[paranoico]

Hello @ElvishJerricco , I would like to know if this issue is related to setTimers problem.

I am retaking subs-cache maintenance and would like to know if it is still an issue.
Thanks in advance.

[ElvishJerricco]

Sorry, this project has mostly left my brain. I don't think I can help much.

[paranoico]

@ElvishJerricco Thanks for your prompt answer, I am closing the issue for now.

Best Regards.

[nicooprat]

Has anyone found a solution? Looks like I'm having the same issue.

[paranoico]

Reopening until I confirm there is no issue with new JS version.

[nicooprat]

Any fix planned? Thanks!

[nicooprat]

When checking on #41 and tried with latest code, allReady.get() was working as expected.

[paranoico]

Thanks a lot @nicooprat

[nicooprat]

To be more precise, it's now reactive, but sometimes allReady.get() still returns false although all subscriptions seem ready. I can't remember where I got this bit of code, but this workaround works (proving that allReady.get() is actually wrong):

_(Subs.cache).chain().values().map((x) => x.ready()).reduce((a,b) => a && b).value()

Subs being the var of my (only) SubsCache object of course.

Edit: allReady.get() and .ready() have the same issue btw.

[paranoico]

Hello,
So the issue still persist, right?

[nicooprat]

Yes, looks like... It happens sometimes, can't get a reproducible test case for now :/

[janat08]

This happens reliably in [/currency/:slug] of blockrazor on Blockrazor/blockrazor#1052 (at that commit cache limit is 10, and that pages has over that amount of subscriptions in total, also routes.js subscriptions property for that route contains bad subscription for "summaries".

[paranoico]

We have seen different behavior than can be originated from this component and seems to be related to Meteor update, mainly the differences come when upgrading from Meteor 1.5.x to 1.6.x.

Here we have no more information on how to reproduce int this, we are currently still trying to find the specific code woth problem.

[janat08]

Blockrazor/blockrazor#1052 reproduces this on route [/currency/:slug].

[thebarty]

Same problem over here.

Subscribing like

// using Blaze Components
onCreated() {
  super.onCreated()
  // TemplateLevel autorun
  this.autorun(() => {
    globalSubscriptionManager.subscribe('sub1')
    globalSubscriptionManager.subscribe('sub2')
  })
}

Problem: globalSubscriptionManager.ready() acts unreliable and after clicking a few links in the ui returns "false"

[paranoico]

Do you have more information on how to reproduce it? It would be helpful.

[thebarty]

Hi guys,

just letting you know: I switched to using the original https://github.com/kadirahq/subs-manager which works much more stable for me.

There seems to be something wrong in the codebase. For me it is globalSubscriptionManager .ready() that acts totally unreliable. Actually all references to the individual subscriptions (which I get via globalSubscriptionManager.subscribe() return (ready()===true). BUT still the global globalSubscriptionManager .ready() returns false.

The bug exists in this package and also in https://atmospherejs.com/blockrazor/subscache-c4.

[paranoico]

Hello @thebarty,

Sorry but what globalSubscriptionManager do you mean?

[paranoico]

Closing again for now, after PR from @ulion

Thank you.