problem: [currency] SubsCache.ready() always returning false

[AshHimself]

Problem: SubsCache.ready() always returning false therefore the LOADING indicator never goes.

Solution: Unknown

[AshHimself]

#1057 seems to be the last PR I can see that it was working.

Looping through all subcaches ready status presents Ready for all subs.

_.values(SubsCache.cache).map(function(x) {console.log (x.ready()); })

[janat08]

I actually turned on SubsCache in #1052.

[AshHimself]

Any ideas on what’s going on ?

…

On Wed, 11 Apr 2018 at 8:48 pm, zhan ishzhanov ***@***.***> wrote: I actually turned on SubsCache in #1052 <#1052>. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#1068 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAJEyiqAPHuz7usqze2Mr1b1S3_CsUmdks5tnfu0gaJpZM4TP28t> .

[janat08]

Would you like me to find out?

[AshHimself]

Sure

…

On Wed, 11 Apr 2018 at 8:51 pm, zhan ishzhanov ***@***.***> wrote: Would you like me to find out? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#1068 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAJEytUFtK7qBbjdcwNZkUNQd2wo0G-Uks5tnfw5gaJpZM4TP28t> .

[janat08]

@blockrazorbot claim

[janat08]

Is upstream issue: ccorcos/meteor-subs-cache#20

this is workaround: _(SubsCache.cache).chain().values().map((x) => x.ready()).reduce((a,b) => a && b).value()
@gazhayes should I look into merging this into our subsCache. What does "_" and chain() mean?

[AshHimself]

I honetly think its working its just the reactiveVar isn't getting updated.

https://github.com/ccorcos/meteor-subs-cache/blob/07a13c0de27dcf9c81e3874edce3df6887cc02d0/src/SubsCache.js#L246

[janat08]

the issue is exclusive to this route though.

[AshHimself]

Does enabling debug bring anymore light to the issue?

SubsCache = new Sub(5, 10, true);

[janat08]

Some subscriptions don't pass in params when they should.

[janat08]

Stops a bunch of subscriptions.

[janat08]

I replied in upstream issue, and we kind of have a workaround. @blockrazorbot unclaim

[gsovereignty]

@janat08 are they fixing it upstream? Or if you know how to fix it just pull request to our version.

[AshHimself]

@gazhayes I believe @janat08 may of resolved the issue in #1070 waiting on merge from you to confirm.

[janat08]

That doesn't resolve.

[janat08]

_(SubsCache.cache).chain().values().map((x) => x.ready()).reduce((a,b) => a && b).value()

Will return true value, but I don't know what this means.

[janat08]

They have an issue for it, I guess they'd like to.

[gsovereignty]

_(SubsCache.cache).chain().values().map((x) => x.ready()).reduce((a,b) => a && b).value()

Will return true value, but I don't know what this means.

You mean because you aren't sure what it's doing upstream or just because it's confusing?
It's Functionalized ES6, @anbud can probably explain this to you better than I can.

They have an issue for it, I guess they'd like to.

Don't count on them fixing it, if you can do it just do it.

[anbud]

The functional code you've posted above just checks if all caches are ready (map maps them to x.ready() and reduce checks if all of them are true, if any of them is not ready, reduce will return false, otherwise the result is true).

[janat08]

That's what original code does: https://github.com/ccorcos/meteor-subs-cache/blob/07a13c0de27dcf9c81e3874edce3df6887cc02d0/src/SubsCache.js#L246

[anbud]

The only difference between the two is that the one you've posted above uses underscore/lodash chaining and respective map and reduce, while the original code uses native js map and reduce. This shouldn't make any difference though, but I'm guessing it does.

[samuelralak]

this issue is not exclusive to the /currency route, I have also spotted it in /problems/:id

the issue is exclusive to this route though.

[janat08]

Couldn't reproduce in /problems/:id. This is just for subs-cache not working. Did you mean #1051?

[janat08]

@blockrazorbot label "done", resolution in #1196