Refactor img_viewer #161
Merged
Refactor img_viewer #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only when chk_box_mask.isChecked()
Make sure tmp_bc_x and _y exist on init, then do not need to check for AttributeError
Make the pens attributes of the class to avoid passing them around between functions
What might actually trigger an error here?
Code now passes flake8
makes it easier to return null
|
This is intended to address #122 |
luisodls
approved these changes
Apr 8, 2020
|
For future reference it isn't necessary to merge into master for testing. You could have just run |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes intended to improve readability and maintainability of this long module.
tryblocks that were obscuring the code pathsThere's still much to do in here, but I'd like to request review now and continue later if this is merged. Testing should mainly concentrate on the mask generation as this is where most changes were made.