Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch to address column definitions. #1

Commits on Nov 1, 2019

  1. Patch to address column definitions.

    In the v4.2.4 schema the following columns are listed as 'text' type columns.
    
    .   learning_outcome_dim.description
    .   module_dim.name
    
    In the MySQL specific liquid files, the learning_outcome_dim table was failing
    to be generated at all (due to a DDL syntax error).  The module_dim.name
    column was too short for some of our actual data and that was generating an
    error.  I went back to the `schema.json` and made adjustment to both file
    (fixing the syntax error and adjusting the column spec).
    
    I also applied similar changes to the MSSQL, Oracle, and PostgresQL variants.
    I am unable to verify that these are syntactically correct, but they match
    the similar constructs for other tables in their respective dialects.
    lafent committed Nov 1, 2019
    Configuration menu
    Copy the full SHA
    ad0b9b3 View commit details
    Browse the repository at this point in the history

Commits on Nov 9, 2019

  1. Reducing module_dim.name to 512 characters

    After some discussions we are reducing the max size for the name column
    to 512 characters for each RDBMS.
    lafent committed Nov 9, 2019
    Configuration menu
    Copy the full SHA
    4be57ab View commit details
    Browse the repository at this point in the history