Patch to address column definitions. #1
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the v4.2.4 schema the following columns are listed as 'text' type columns.
. learning_outcome_dim.description
. module_dim.name
In the MySQL specific liquid files, the learning_outcome_dim table was failing
to be generated at all (due to a DDL syntax error). The module_dim.name
column was too short for some of our actual data and that was generating an
error. I went back to the
schema.json
and made adjustment to both file(fixing the syntax error and adjusting the column spec).
I also applied similar changes to the MSSQL, Oracle, and PostgresQL variants.
I am unable to verify that these are syntactically correct, but they match
the similar constructs for other tables in their respective dialects.