libtbx: fix for Windows stdout redirection #416
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
bkpoon
commented
Nov 20, 2019
bkpoon
commented
- New Windows console in Python 3.6 and greater does not work with os.dup2
- https://bugs.python.org/issue30555
- bpo-30555: Fix WindowsConsoleIO errors in the presence of fd redirection python/cpython#1927
- https://stackoverflow.com/questions/52373180/python-on-windows-handle-invalid-when-redirecting-stdout-writing-to-file
bkpoon
force-pushed
the
windows_fix
branch
2 times, most recently
from
8e7acce
to
6ff0ac5
Compare
|
@Oeffner Here the changes to get cctbx to compile on Windows for Python 3. The header changes just picks an earlier version of msinttypes. The stdint.h from Microsoft seems to be still causing issues with VC++ 14.0. |
- New Windows console in Python 3.6 and greater does not work with os.dup2 - https://bugs.python.org/issue30555 - python/cpython#1927 - https://stackoverflow.com/questions/52373180/python-on-windows-handle-invalid-when-redirecting-stdout-writing-to-file
- Use headers from https://github.com/chemeris/msinttypes - Use commit 7636cabe55318824dc702d15b69711f5d7c30250, not the latest
|
Rolled into #409 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.