Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix treatment of NaN in histogram #479

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix treatment of NaN in histogram #479

wants to merge 2 commits into from
+8 −1

Conversation

graeme-winter
Copy link
Contributor

Includes test to assert this behaviour. Means histogram behaves as expected
for #478 however issues with min() and max() remain.

@graeme-winter
Fix treatment of NaN in histogram
ceb5001 
Includes test to assert this behaviour. Means histogram behaves as expected
for #478 however issues with min() and max() remain
@phyy-nx phyy-nx mentioned this pull request May 26, 2020
Open
@ndevenish
Copy link
Contributor

This has a bug where ignored nan's don't contribute to the n_out_of_slot_range_ count - they just disappear. It also seems vaguely whether isnan always works properly, even under -ffast-math? Though perhaps that part doesn't matter..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@graeme-winter @ndevenish