Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scons: prevent LIBPATH from being overwritten #221

Merged
merged 1 commit into from
Sep 26, 2020
Merged

scons: prevent LIBPATH from being overwritten #221

merged 1 commit into from
Sep 26, 2020

Conversation

bkpoon
Copy link
Member

@bkpoon bkpoon commented Sep 25, 2020

This is for building dxtbx with dependencies located in a general $PREFIX directory (e.g. a conda environment).

By overwriting LIBPATH in the SCons environment, any additional paths that are added outside of this SConscript are lost. This pull request changes the replacement with appending the paths in the current environment.

@Anthchirp Anthchirp merged commit 567f8f1 into master Sep 26, 2020
@Anthchirp Anthchirp deleted the libpath branch September 26, 2020 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants