New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optionally use only pycbf bindings without cbflib or cbflib_adaptbx #368
Conversation
Codecov Report
@@ Coverage Diff @@
## main #368 +/- ##
==========================================
- Coverage 66.56% 66.20% -0.37%
==========================================
Files 184 184
Lines 16652 16779 +127
Branches 2193 2202 +9
==========================================
+ Hits 11084 11108 +24
- Misses 5006 5106 +100
- Partials 562 565 +3 |
This allows it to be read by TextIOWrapper
Not ready to commit to this level of interface yet.
I've just merged in the branch from #366, which means that all tests now pass (excluding the detectorbase-specific tests mentioned above) |
with 6737862, none of the actively tested formats in the |
This is a PR for changes to optionally support using purely python-based bindings to CBFlib and libimg.
cbflib_adaptbx
is not present (Many formats currently initialise CBF detectorbase even if they don't use, and these are tested)IF using new pycbf:
cbf_read_buffered_file
- use pycbf binding insteadOtherwise, everything should work exactly as it did before.
I've run this both with a plain bootstrap and also a bootstrap where I've
rm -rf
'dcbflib/
andcbflib_adaptbx/
before configuring the build (I don't know how cbflib_adaptbx dependency is normally pulled in, but it doesn't seem to be via a module?).At the moment, two tests fail - both readingdials_regression/image_examples/SPring8_ADSC_SN916/Xtal17-2phi_3_015.cbf
- which is the only image example in the regression tests that resolves toFormatCBFFull
- #366 is a WIP example of how we could remove this dependency and read the format directly.