Explicit Format support for non-Dectris byte-offset CBF files #366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
ndevenish
changed the title
ndevenish
changed the title
Not ready to commit to this level of interface yet.
Anthchirp
approved these changes
Oct 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Note: PR made by @graeme-winter but this message has been re-written by @ndevenish)
This adds explicit format support for CBF files compressed with byte-offset compression, but is not recorded on a Pilatus detector (e.g. would be picked up by
FormatCBFFullPilatus).This means that reading the example ADSC QUANTUM315 SN916 images in
dials_regression/image_examples/SPring8_ADSC_SN916can be read directly, without DetectorBase.