Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hdf5plugin dependency #373

Merged
merged 2 commits into from Jun 3, 2021
Merged

Add hdf5plugin dependency #373

merged 2 commits into from Jun 3, 2021

Conversation

Anthchirp
Copy link
Member

over the previously used (and abandoned) hdf5-external-filter-plugins

See also: dials/dials#1733

Anthchirp and others added 2 commits June 2, 2021 12:28
over the previously used (and abandoned) hdf5-external-filter-plugins
@codecov
Copy link

codecov bot commented Jun 2, 2021

Codecov Report

Merging #373 (31eb6a7) into main (63a9625) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #373      +/-   ##
==========================================
- Coverage   48.59%   48.58%   -0.02%     
==========================================
  Files         235      235              
  Lines       19437    19429       -8     
  Branches     2738     2738              
==========================================
- Hits         9445     9439       -6     
+ Misses       9485     9483       -2     
  Partials      507      507              

@Anthchirp Anthchirp merged commit 289b29f into main Jun 3, 2021
@Anthchirp Anthchirp deleted the hdf5plugin branch June 3, 2021 15:29
@Anthchirp
Copy link
Member Author

Anthchirp commented Jun 4, 2021

If you have an existing DIALS development installation then you should follow these steps when convenient:

  • Update the dxtbx and dials repositories
  • Run
    conda remove hdf5-external-filter-plugins
    and
    conda install -c conda-forge hdf5plugin
    to change the installed packages.
    Please see Add hdf5plugin dependency dials/dials#1733 (comment) if the remove step takes a very long time or produces unexpected results.
  • This can then be followed by a
    make reconf
    in the build directory to make sure the build is up-to-date.

Future bootstrapped environments will have these changes included automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants