Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hdf5plugin dependency #1733

Merged
merged 2 commits into from Jun 3, 2021
Merged

Add hdf5plugin dependency #1733

merged 2 commits into from Jun 3, 2021

Conversation

Anthchirp
Copy link
Member

over the previously used (and abandoned) hdf5-external-filter-plugins

over the previously used (and abandoned) hdf5-external-filter-plugins
@Anthchirp
Copy link
Member Author

Successfully ran regression tests on a newly bootstrapped environment

@codecov
Copy link

codecov bot commented Jun 2, 2021

Codecov Report

Merging #1733 (b96dfde) into main (525bdab) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1733   +/-   ##
=======================================
  Coverage   67.22%   67.22%           
=======================================
  Files         616      616           
  Lines       69037    69037           
  Branches     9619     9619           
=======================================
+ Hits        46407    46409    +2     
+ Misses      20687    20685    -2     
  Partials     1943     1943           

@Anthchirp Anthchirp merged commit d490cbe into main Jun 3, 2021
@Anthchirp Anthchirp deleted the hdf5plugin branch June 3, 2021 15:33
@Anthchirp
Copy link
Member Author

If you have an existing DIALS development installation then you should follow these steps when convenient:

  • Update the dxtbx and dials repositories
  • Run
    conda remove hdf5-external-filter-plugins
    and
    conda install -c conda-forge hdf5plugin
    to change the installed packages.
  • This can then be followed by a
    make reconf
    in the build directory to make sure the build is up-to-date.

Future bootstrapped environments will have these changes included automatically.

@Anthchirp
Copy link
Member Author

There is a chance that conda gets its packages in a twist during the remove step and will run for a very long time before offering to upgrade many packages (and install new ones). You can also use the command
conda remove --force hdf5-external-filter-plugins hdf5-external-filter-plugins-bitshuffle hdf5-external-filter-plugins-bzip2 hdf5-external-filter-plugins-lz4 to remove the old plugins, which will not suffer from this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants