Delta: fetchSettlementHistory, createExpiredOptionMarket #18675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added fetchSettlementHistory and createExpiredOptionMarket to Delta:
```
delta.fetchSettlementHistory (BTC/USDT:USDT-130723-29000-C)
2023-07-27T03:16:20.747Z iteration 0 passed in 4150 ms
symbol | price | timestamp | datetime
---------------------------------------------------------------------------------------
BTC/USDT:USDT-130723-29000-C | 1555.784058200865 | 1689249600000 | 2023-07-13T12:00:00Z
1 objects
```
```
delta.fetchSettlementHistory (C-BTC-29000-130723)
2023-07-27T03:17:03.101Z iteration 0 passed in 4590 ms
symbol | price | timestamp | datetime
---------------------------------------------------------------------------------------
BTC/USDT:USDT-130723-29000-C | 1555.784058200865 | 1689249600000 | 2023-07-13T12:00:00Z
1 objects
```
carlosmiei
reviewed
Jul 27, 2023
| const result = this.safeValue (response, 'result', []); | ||
| const settlements = this.parseSettlements (result, market); | ||
| const sorted = this.sortBy (settlements, 'timestamp'); | ||
| return this.filterBySymbolSinceLimit (sorted, market['symbol'], since, limit); |
There was a problem hiding this comment.
hum for some reason, the python version returns an empty array
|
LGTM |
carlosmiei
approved these changes
Jul 27, 2023
kroitor
pushed a commit
that referenced
this pull request
Jul 27, 2023
Delta: fetchSettlementHistory, createExpiredOptionMarket [ci skip]
samgermain
reviewed
Jan 2, 2024
| } else if (symbol in this.markets_by_id) { | ||
| const markets = this.markets_by_id[symbol]; | ||
| return markets[0]; | ||
| } else if ((symbol.indexOf ('-C') > -1) || (symbol.indexOf ('-P') > -1) || (symbol.indexOf ('C')) || (symbol.indexOf ('P'))) { |
There was a problem hiding this comment.
@Dan-krm This logic isn't good for a few reasons.
- first, symbol.indexOf ('C') evaluates to
-1so the boolean version of this is true, so this evaluates to true whenever the letterCorPis not present, but it also evaluates to true whenever C/P is at any index other than 0, the only timesymbol.indexOf ('C')evaluates to false is when C is the first letter of symbol, but then because we also havesymbol.indexOf ('P')right after, this line will always evaluate to true, because the first letter ofsymbolcan't be bothCandP.
you can test this in node
const symbol = "market";
undefined
> Boolean(symbol.indexOf ('P'))
true
- second, you can't just test for the presence of
CorPto see if the symbol is an option symbol, by this logic, this symbol would be an option symbolETH/BTC
can you update this line to use some logic that is correct? Thanks
There was a problem hiding this comment.
@samgermain Yeah definitely, I'll adjust this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added fetchSettlementHistory and createExpiredOptionMarket to Delta:
https://www.delta.exchange/app/expired_futures_and_options