Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(base) - handleParamString2, handleParamInteger2 #22042

Merged
merged 12 commits into from
May 17, 2024

Conversation

ttodua
Copy link
Member

@ttodua ttodua commented Apr 3, 2024

No description provided.

@ttodua
Copy link
Member Author

ttodua commented Apr 3, 2024

@carlosmiei can you make a quick approval for this?

@ttodua ttodua marked this pull request as draft May 1, 2024 19:27
@ttodua
Copy link
Member Author

ttodua commented May 1, 2024

@carlosmiei can you give me a hand here?

[ value, params ] = this.handleOptionAndParams (...)
if (condition) {
    [ value, params ] = this.handleOptionAndParams (...)

is transpiled into c# like:

var valueparametersVariable = this.handleOptionAndParams(...);
value = ((IList<object>)valueparametersVariable)[0];
parameters = ((IList<object>)valueparametersVariable)[1];

if (...) {
   var valueparametersVariable = this.handleOptionAndParams(...);

so as you see, var is declared two times, in lower scope too, causing errors in build: https://app.travis-ci.com/github/ccxt/ccxt/builds/270262306#L2672

and I couldn't find where that specific transpilation is being done in chsarp-transpiler.ts to amend

@ttodua ttodua marked this pull request as ready for review May 16, 2024 16:38
@ttodua
Copy link
Member Author

ttodua commented May 16, 2024

@carlosmiei this should be ready after travis finishes

@carlosmiei carlosmiei merged commit c9058e6 into ccxt:master May 17, 2024
0 of 2 checks passed
@carlosmiei carlosmiei deleted the handleParam2-methods branch May 17, 2024 11:45
kroitor pushed a commit that referenced this pull request May 17, 2024
* feat(base) - handleParamString2, handleParamInteger2

* update hparams2

* rename inside

* base

* binance

* cryptocom

* fix c# build

* fix build

* handleOptionAndParams call

* fix c# build

---------

Co-authored-by: carlosmiei <43336371+carlosmiei@users.noreply.github.com>

[ci skip]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants