fix(coinex): handleErrors should also check for "OK" #22479
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
handleErrors
method checks for "Ok", but some endpoints return "OK" instead. This causes anExchangeError
to be thrown for API responses that use "OK" but simply have no data.An example is the pending positions endpoint (https://api.coinex.com/perpetual/v1/position/pending) while there are no open pending positions.
Also in their docs it isn't consistent if you look at the examples:
And here is a live example for the V2 of it returning "OK": https://api.coinex.com/v2/maintain/info