gateio: (minor) do not crash in parseOrder() on empty timestamp #3033
Conversation
|
Could you perhaps create label "minor" for changes that needs very simple and quick code review? Sort of like "minor edit" in wikipedia or something?.. |
egorFiNE
changed the title
| @@ -378,7 +381,7 @@ module.exports = class gateio extends Exchange { | |||
| } | |||
| return { | |||
| 'id': id, | |||
| 'datetime': this.iso8601 (timestamp), | |||
There was a problem hiding this comment.
I'm trying to understand why it did crash there, whereas it actually should've worked ok... the iso8601 method is designed to work with undefined values, unless there was some other type of value in the timestamp (not undefined, but null, maybe?)
|
It crashes in multiple exchanges and multiple cases. I thought as well to update the base method. Shall we? |
|
And |
That would be awesome! |
Here you go: #3043. PHP and Python versions will follow today from my coworkers with similar branch names. |
No description provided.