Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exchange: datetime functions sanitized input #3043

Merged
merged 2 commits into from
Jun 5, 2018
Merged

Exchange: datetime functions sanitized input #3043

merged 2 commits into from
Jun 5, 2018

Conversation

egorFiNE
Copy link
Contributor

@egorFiNE egorFiNE commented Jun 5, 2018

  • also, tests added

@egorFiNE egorFiNE mentioned this pull request Jun 5, 2018
Merged
@egorFiNE
Copy link
Contributor Author

egorFiNE commented Jun 5, 2018

PHP and Python versions will follow today from my coworkers with similar branch names.

@kroitor
Copy link
Member

kroitor commented Jun 5, 2018 •
edited

This is great! One question, however: can you please change the default value from null to undefined? That way it would be more portable to other languages ) Thx!

@kroitor kroitor self-assigned this Jun 5, 2018
@egorFiNE
Copy link
Contributor Author

egorFiNE commented Jun 5, 2018

from null to undefined

Boom.

@kroitor kroitor merged commit c9c7019 into ccxt:master Jun 5, 2018
@egorFiNE egorFiNE deleted the fix_js_datetime_functions branch June 5, 2018 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@kroitor kroitor

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@egorFiNE @kroitor