🐛 Fix PiExpression division and multiplication arithmetic
#549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #549 +/- ##
=====================================
Coverage 91.0% 91.1%
=====================================
Files 131 131
Lines 13664 13667 +3
Branches 2150 2150
=====================================
+ Hits 12444 12451 +7
+ Misses 1220 1216 -4
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| result.type = ConstEvalValue::Type::ConstBool; | ||
| break; | ||
| case BinaryExpression::Equal: | ||
| result.value = lhs == rhs; |
Check notice
Code scanning / CodeQL
Equality test on floating-point values
| result.type = ConstEvalValue::Type::ConstBool; | ||
| break; | ||
| case BinaryExpression::NotEqual: | ||
| result.value = lhs != rhs; |
Check notice
Code scanning / CodeQL
Equality test on floating-point values
| Token(const Kind k, const size_t l, const size_t c, std::string s) | ||
| : kind(k), line(l), col(c), endLine(l), endCol(c), str(std::move(s)) {} | ||
|
|
||
| static std::string kindToString(const Kind kind) { |
Check warning
Code scanning / CodeQL
Poorly documented large function
burgholzer
added
fix
burgholzer
approved these changes
Feb 12, 2024
burgholzer
changed the title
PiExpression division and multiplication arithmetic
4 tasks
burgholzer
added a commit
that referenced
this pull request
Feb 12, 2024
## Description This PR adds the last remaining unsupported gates to the ZX library. In the process, it also introduces a new convenience function for integer division of parameter expressions that simplifies some code. In conjunction with #549, this also fixes #486. Fixes #343 ## Checklist: <!--- This checklist serves as a reminder of a couple of things that ensure your pull request will be merged swiftly. --> - [x] The pull request only contains commits that are related to it. - [x] I have added appropriate tests and documentation. - [x] I have made sure that all CI jobs on GitHub pass. - [x] The pull request introduces no new warnings and follows the project's style guidelines. --------- Signed-off-by: burgholzer <burgholzer@me.com> Co-authored-by: Tom Peham <pehamtom@gmx.at>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix Arithmetic Issues when dividing or multiplying a
PiExpressionby adouble.Partially solves #486
Checklist: