Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ remove redundant start parameter from DD multiplication routine #576

Merged
merged 2 commits into from
Mar 28, 2024

Conversation

burgholzer
Copy link
Member

Description

This small PR removes a no-longer-needed start parameter of the DD multiplication routines.

Checklist:

  • The pull request only contains commits that are related to it.
  • I have added appropriate tests and documentation.
  • I have made sure that all CI jobs on GitHub pass.
  • The pull request introduces no new warnings and follows the project's style guidelines.

Signed-off-by: burgholzer <burgholzer@me.com>
@burgholzer burgholzer added enhancement New feature or request refactor Anything related to code refactoring DD Anything related to the DD package c++ Anything related to C++ code labels Mar 27, 2024
@burgholzer burgholzer added this to the DD Package Improvements milestone Mar 27, 2024
@burgholzer burgholzer self-assigned this Mar 27, 2024
@burgholzer burgholzer enabled auto-merge (squash) March 27, 2024 17:07
Signed-off-by: burgholzer <burgholzer@me.com>
Copy link

codecov bot commented Mar 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.2%. Comparing base (df43b4a) to head (f06e8fd).

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main    #576   +/-   ##
=====================================
  Coverage   91.2%   91.2%           
=====================================
  Files        132     132           
  Lines      13904   13904           
  Branches    2203    2203           
=====================================
  Hits       12692   12692           
  Misses      1212    1212           
Flag Coverage Δ
cpp 90.9% <100.0%> (ø)
python 99.5% <ø> (ø)
Files Coverage Δ
include/mqt-core/dd/Package.hpp 97.6% <100.0%> (ø)

@burgholzer burgholzer merged commit ed17e0c into main Mar 28, 2024
37 checks passed
@burgholzer burgholzer deleted the remove-redundant-start-parameter branch March 28, 2024 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ Anything related to C++ code DD Anything related to the DD package enhancement New feature or request refactor Anything related to code refactoring
Projects
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

1 participant