Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No more explicit DD terminals #265

Merged
merged 12 commits into from
Jul 24, 2023
Merged

No more explicit DD terminals #265

merged 12 commits into from
Jul 24, 2023

Conversation

hillmich
Copy link
Contributor

  • Explicit DD terminals have been replaced by nullptr
  • Allows for more qubits
  • Requires changes to some loops

@hillmich
No more explicit DD terminals
f98293f 
- Explicit DD terminals have been replaced by nullptr
- Allows for more qubits
- Requires changes to some loops
@hillmich hillmich added enhancement Anything related to improvements of the existing library dependencies Pull requests that update a dependency file labels Jul 21, 2023
@hillmich hillmich self-assigned this Jul 21, 2023
@codecov
Copy link

codecov bot commented Jul 21, 2023 •
edited
Loading

Codecov Report

Merging #265 (8596ef2) into main (b1418e9) will decrease coverage by 0.2%.
The diff coverage is 96.7%.

@@           Coverage Diff           @@
##            main    #265     +/-   ##
=======================================
- Coverage   95.1%   94.9%   -0.2%     
=======================================
  Files         20      20             
  Lines       1939    1938      -1     
  Branches     345     344      -1     
=======================================
- Hits        1844    1841      -3     
- Misses        95      97      +2
Impacted Files Coverage Δ
src/Simulator.cpp 96.0% <90.9%> (-1.1%) ⬇️
include/HybridSchrodingerFeynmanSimulator.hpp 89.6% <100.0%> (ø)
src/CircuitSimulator.cpp 92.0% <100.0%> (ø)
src/DeterministicNoiseSimulator.cpp 94.2% <100.0%> (ø)
src/GroverSimulator.cpp 100.0% <100.0%> (ø)
src/HybridSchrodingerFeynmanSimulator.cpp 97.3% <100.0%> (ø)
src/PathSimulator.cpp 89.0% <100.0%> (ø)
src/ShorFastSimulator.cpp 95.5% <100.0%> (ø)
src/ShorSimulator.cpp 96.1% <100.0%> (ø)
src/StochasticNoiseSimulator.cpp 96.0% <100.0%> (ø)

burgholzer
burgholzer requested changes Jul 21, 2023
View reviewed changes
Copy link
Member

@burgholzer burgholzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of small comments that I believe are worth addressing.

src/Simulator.cpp Outdated Show resolved Hide resolved
src/Simulator.cpp Outdated Show resolved Hide resolved
src/Simulator.cpp Outdated Show resolved Hide resolved
@hillmich hillmich requested a review from burgholzer July 24, 2023 10:14
@github-actions
Copy link
Contributor

Cpp-Linter Report ✔️

No problems need attention.

Have any feedback or feature suggestions? Share it here.

@hillmich hillmich enabled auto-merge (squash) July 24, 2023 10:20
@hillmich hillmich merged commit 08304cf into main Jul 24, 2023
18 checks passed
@hillmich hillmich deleted the eliminate-dd-terminals branch July 24, 2023 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@burgholzer burgholzer burgholzer approved these changes

Assignees

@hillmich hillmich

Labels
dependencies Pull requests that update a dependency file enhancement Anything related to improvements of the existing library
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hillmich @burgholzer