Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix broken manylinux wheels #294

Merged
merged 1 commit into from
Sep 13, 2023
Merged

🐛 Fix broken manylinux wheels #294

merged 1 commit into from
Sep 13, 2023

Conversation

burgholzer
Copy link
Member

Description

Due to the way Linux wheels are built by cibuildwheel (in a manylinux docker container), environment varaiables are not passed down to the container. As a result the CI environment variable is not defined in the docker container, which is used to flip on the DEPLOY CMake setting automatically.
This has lead to manylinux wheels being built with -march=native that might produce errors like

Illegal instruction (core dumped)

when trying to import the respective packages.

This PR fixes this by making sure that DEPLOY="ON" within cibuildwheel.

Fixes #288

Checklist:

  • The pull request only contains commits that are related to it.
  • I have added appropriate tests and documentation.
  • I have made sure that all CI jobs on GitHub pass.
  • The pull request introduces no new warnings and follows the project's style guidelines.

Signed-off-by: burgholzer <burgholzer@me.com>
@burgholzer burgholzer added continuous integration Anything related to the CI setup packaging Anything related to Python packaging fix Anything related to bugfixes labels Sep 13, 2023
@burgholzer burgholzer self-assigned this Sep 13, 2023
@burgholzer burgholzer enabled auto-merge (squash) September 13, 2023 08:40
@burgholzer burgholzer merged commit af65305 into main Sep 13, 2023
28 checks passed
@burgholzer burgholzer deleted the fix-manylinux-wheels branch September 13, 2023 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
continuous integration Anything related to the CI setup fix Anything related to bugfixes packaging Anything related to Python packaging
Projects
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

🐛 Newest version crashes on Docker
1 participant