Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ DDSIM version of Estimator primitive #327

Merged
merged 10 commits into from
Dec 22, 2023
Merged

✨ DDSIM version of Estimator primitive #327

merged 10 commits into from
Dec 22, 2023

Conversation

andresbar98
Copy link
Contributor

@andresbar98 andresbar98 commented Dec 11, 2023

Creating a DDSIM version of the second qiskit primitive: The "Estimator". This primitive calculates expectation values of observables with respect to the output state of a QuantumCircuit object.
Code is adapted from the BackendEstimator class from https://qiskit.org/documentation/stubs/qiskit.primitives.BackendEstimator.html, which in turn is a child class of the more general BaseEstimator class https://qiskit.org/documentation/stubs/qiskit.primitives.BaseEstimator.html.

@andresbar98 andresbar98 marked this pull request as draft December 11, 2023 02:29
Copy link

codecov bot commented Dec 11, 2023

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (37a442c) 92.6% compared to head (c21519c) 92.7%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main    #327     +/-   ##
=======================================
+ Coverage   92.6%   92.7%   +0.1%     
=======================================
  Files         34      35      +1     
  Lines       2584    2702    +118     
  Branches     348     348             
=======================================
+ Hits        2393    2505    +112     
- Misses       191     197      +6     
Flag Coverage Δ *Carryforward flag
cpp 94.4% <ø> (ø) Carriedforward from 37a442c
python 87.9% <95.0%> (+1.3%) ⬆️

*This pull request uses carry forward flags. Click here to find out more.

Files Coverage Δ
src/mqt/ddsim/qasmsimulator.py 98.9% <100.0%> (ø)
src/mqt/ddsim/primitives/estimator.py 94.9% <94.9%> (ø)

@burgholzer burgholzer added python Pull requests that update Python code minor Part of a minor release feature New feature or request labels Dec 11, 2023
@burgholzer burgholzer added this to the Qiskit Primitives milestone Dec 11, 2023
@burgholzer burgholzer linked an issue Dec 11, 2023 that may be closed by this pull request
3 tasks
@burgholzer burgholzer changed the title DDSIM version of Estimator primitive (2nd version) ✨ DDSIM version of Estimator primitive Dec 22, 2023
@burgholzer burgholzer marked this pull request as ready for review December 22, 2023 19:25
Copy link
Member

@burgholzer burgholzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is looking good! So let's get it in before Christmas 🎉
I just applied some minor corrections to the docs and merged the latest changes from main in.
Many thanks for this contribution.

@burgholzer burgholzer enabled auto-merge (squash) December 22, 2023 19:43
@burgholzer burgholzer merged commit 6f09e30 into cda-tum:main Dec 22, 2023
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request minor Part of a minor release python Pull requests that update Python code
Projects
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

✨ DDSIM Versions of Qiskit Primitives
2 participants