Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⬆️ update mqt-core #337

Merged
merged 12 commits into from
Jan 29, 2024
Merged

⬆️ update mqt-core #337

merged 12 commits into from
Jan 29, 2024

Conversation

burgholzer
Copy link
Member

Description

This PR updates the mqt-core submodule and brings in some further advancements from #355.
Specifically, it switches to using FetchContent for obtaining mqt-core.
Per default, it is pointed to the vendored submodule via an overridable CMake variable.

Checklist:

  • The pull request only contains commits that are related to it.
  • I have added appropriate tests and documentation.
  • I have made sure that all CI jobs on GitHub pass.
  • The pull request introduces no new warnings and follows the project's style guidelines.

Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
@burgholzer burgholzer added dependencies Pull requests that update a dependency file c++ Anything related to C++ code labels Jan 29, 2024
@burgholzer burgholzer self-assigned this Jan 29, 2024
Copy link

codecov bot commented Jan 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5455bc5) 92.6% compared to head (e5de0e1) 92.7%.
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main    #337     +/-   ##
=======================================
+ Coverage   92.6%   92.7%   +0.1%     
=======================================
  Files         35      35             
  Lines       2683    2666     -17     
  Branches     347     346      -1     
=======================================
- Hits        2486    2473     -13     
+ Misses       197     193      -4     
Flag Coverage Δ
cpp 94.6% <ø> (+0.1%) ⬆️
python 87.7% <ø> (-0.3%) ⬇️
Files Coverage Δ
src/mqt/ddsim/hybridqasmsimulator.py 90.9% <ø> (-0.5%) ⬇️
src/mqt/ddsim/pathqasmsimulator.py 50.9% <ø> (-1.4%) ⬇️
src/mqt/ddsim/qasmsimulator.py 98.9% <ø> (-0.1%) ⬇️
src/mqt/ddsim/unitarysimulator.py 87.5% <ø> (-0.6%) ⬇️

... and 2 files with indirect coverage changes

Signed-off-by: burgholzer <burgholzer@me.com>
@burgholzer burgholzer merged commit 225e078 into main Jan 29, 2024
35 checks passed
@burgholzer burgholzer deleted the update-core branch January 29, 2024 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ Anything related to C++ code dependencies Pull requests that update a dependency file
Projects
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

1 participant