Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ add sp-repo-review to pre-commit check #355

Merged
merged 1 commit into from
Feb 23, 2024
Merged

Conversation

burgholzer
Copy link
Member

@burgholzer burgholzer commented Feb 23, 2024

Description

This PR adds a new pre-commit check that runs Scientific Python's Repo Review and checks for the use of established best practices throughout the project.

Adding the check immediately revealed the use of some deprecated settings.

Checklist:

  • The pull request only contains commits that are related to it.
  • I have added appropriate tests and documentation.
  • I have made sure that all CI jobs on GitHub pass.
  • The pull request introduces no new warnings and follows the project's style guidelines.

Signed-off-by: burgholzer <burgholzer@me.com>
@burgholzer burgholzer added continuous integration Anything related to the CI setup code quality Anything related to code quality and code style. labels Feb 23, 2024
@burgholzer burgholzer self-assigned this Feb 23, 2024
@burgholzer burgholzer enabled auto-merge (squash) February 23, 2024 10:36
@burgholzer burgholzer merged commit a76caa6 into main Feb 23, 2024
29 checks passed
@burgholzer burgholzer deleted the sp-repo-review branch February 23, 2024 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code quality Anything related to code quality and code style. continuous integration Anything related to the CI setup
Projects
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

1 participant