Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🧹 Add missing header and cleanup old code #343

Merged
merged 4 commits into from
Feb 8, 2024
Merged

Conversation

burgholzer
Copy link
Member

Description

This tiny PR adds a header that was missing for compiling with gcc and removes some special handling from the times where Barrier Statements were still considered non-unitary.

Checklist:

  • The pull request only contains commits that are related to it.
  • I have added appropriate tests and documentation.
  • I have made sure that all CI jobs on GitHub pass.
  • The pull request introduces no new warnings and follows the project's style guidelines.

@burgholzer burgholzer added c++ Anything related to C++ code code quality Anything related to code quality and code style. labels Feb 8, 2024
@burgholzer burgholzer self-assigned this Feb 8, 2024
Copy link

codecov bot commented Feb 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (10dec73) 92.7% compared to head (fbfd5ab) 92.8%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main    #343     +/-   ##
=======================================
+ Coverage   92.7%   92.8%   +0.1%     
=======================================
  Files         35      35             
  Lines       2666    2664      -2     
  Branches     346     345      -1     
=======================================
+ Hits        2473    2474      +1     
+ Misses       193     190      -3     
Flag Coverage Δ
cpp 94.7% <100.0%> (+0.1%) ⬆️
python 87.7% <ø> (ø)
Files Coverage Δ
src/CircuitSimulator.cpp 92.7% <100.0%> (-0.2%) ⬇️

... and 1 file with indirect coverage changes

@burgholzer burgholzer merged commit c66c33d into main Feb 8, 2024
35 checks passed
@burgholzer burgholzer deleted the small-fixes branch February 8, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ Anything related to C++ code code quality Anything related to code quality and code style.
Projects
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

1 participant