Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Stripping DDs of their identity #361

Merged
merged 6 commits into from
Mar 24, 2024
Merged

✨ Stripping DDs of their identity #361

merged 6 commits into from
Mar 24, 2024

Conversation

burgholzer
Copy link
Member

@burgholzer burgholzer commented Mar 21, 2024

Description

This PR pulls in the changes from cda-tum/mqt-core#358, which considerably changes the way matrix decision diagrams are represented. Particularly, any node resembling the identity is now eliminated and only implicitly represented.
This further compacts the representation of quantum gates and makes the identity the most compact it can be---a single terminal node.
The overall performance improvements are still to be evaluated.

Checklist:

  • The pull request only contains commits that are related to it.
  • I have added appropriate tests and documentation.
  • I have made sure that all CI jobs on GitHub pass.
  • The pull request introduces no new warnings and follows the project's style guidelines.

Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
@burgholzer burgholzer added enhancement Anything related to improvements of the existing library dependencies Pull requests that update a dependency file submodules Pull requests that update Submodules code minor Part of a minor release c++ Anything related to C++ code labels Mar 21, 2024
@burgholzer burgholzer added this to the DDSIM 2.0 milestone Mar 21, 2024
@burgholzer burgholzer self-assigned this Mar 21, 2024
Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
Copy link

codecov bot commented Mar 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.7%. Comparing base (cda4a73) to head (eadeaaf).

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main    #361   +/-   ##
=====================================
  Coverage   92.6%   92.7%           
=====================================
  Files         37      37           
  Lines       2549    2552    +3     
  Branches     309     310    +1     
=====================================
+ Hits        2362    2366    +4     
+ Misses       187     186    -1     
Flag Coverage Δ
cpp 94.6% <100.0%> (+<0.1%) ⬆️
python 87.7% <ø> (ø)
Files Coverage Δ
include/DeterministicNoiseSimulator.hpp 100.0% <100.0%> (ø)
src/HybridSchrodingerFeynmanSimulator.cpp 97.3% <100.0%> (+<0.1%) ⬆️
src/ShorFastSimulator.cpp 95.3% <100.0%> (ø)
src/ShorSimulator.cpp 96.1% <100.0%> (ø)

... and 1 file with indirect coverage changes

Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
@burgholzer burgholzer enabled auto-merge (squash) March 24, 2024 22:51
@burgholzer burgholzer merged commit c65bb4a into main Mar 24, 2024
37 checks passed
@burgholzer burgholzer deleted the identity-removal branch March 24, 2024 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ Anything related to C++ code dependencies Pull requests that update a dependency file enhancement Anything related to improvements of the existing library minor Part of a minor release submodules Pull requests that update Submodules code
Projects
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant